Skip to content

chore(parser): replace util-dynamodb with commons package #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2025
Merged

chore(parser): replace util-dynamodb with commons package #3493

merged 4 commits into from
Jan 20, 2025

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Jan 20, 2025 •
edited
Loading

Summary

This PR removes @aws-sdk/util-dynamodb dependency in favour of commons package, since we ported the added our own implementation.

Changes

Please provide a summary of what's being changed

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3492

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d self-assigned this Jan 20, 2025
@am29d am29d requested a review from a team January 20, 2025 09:01
@am29d am29d requested a review from a team as a code owner January 20, 2025 09:01
@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Jan 20, 2025
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 20, 2025
@am29d am29d added the parser This item relates to the Parser Utility label Jan 20, 2025
@am29d am29d marked this pull request as draft January 20, 2025 10:35
@pull-request-size pull-request-size bot added size/S PR between 10-29 LOC and removed size/XS PR between 0-9 LOC labels Jan 20, 2025
@pull-request-size pull-request-size bot added size/XS PR between 0-9 LOC and removed size/S PR between 10-29 LOC labels Jan 20, 2025
@am29d am29d marked this pull request as ready for review January 20, 2025 10:48
@am29d am29d requested a review from dreamorosi January 20, 2025 10:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dreamorosi dreamorosi merged commit 66cb1e0 into main Jan 20, 2025
38 checks passed
@dreamorosi dreamorosi deleted the issue3492/Maintenance-add-aws-sdkutil-dynamodb-to-peerDependenciesMeta-as-optional branch January 20, 2025 11:05
@am29d am29d changed the title chore(parser): add util-dynamodb as optional dependency chore(parser): replace util-dynamodb with commons package Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@am29d am29d

Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. parser This item relates to the Parser Utility size/XS PR between 0-9 LOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: remove aws-sdk/util-dynamodb dependency in favour of commons package
2 participants
@am29d @dreamorosi